[7.15] Properly handle wildcards in data stream deletion requests (#78463)#78509
Merged
danhermann merged 1 commit intoelastic:7.15from Sep 30, 2021
Merged
Conversation
danhermann
added
>bug
backport
:StorageEngine/Data streams
elasticmachine
added
the
Team:Data Management (obsolete)
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause of this bug was the replacement of the wildcard expression in the request's
indicesmember with the actual data streams that expression matched. In the case that the authz code had already replaced it with the*,-*token that means "no authorized data streams", the expression would be evaluated again, would match no data streams, and would set theindicesmember to an empty array. An empty array is equivalent to*, so all data streams would then be deleted.Fixes #78422
Backport of #78463